Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi arch win exporter #2450

Merged

Conversation

henrik-m
Copy link
Contributor

Make windows-exporter compatible with multiple Windows versions

@henrik-m henrik-m requested a review from a team as a code owner June 27, 2024 16:33
@github-actions github-actions bot added the stale label Aug 27, 2024
@philipgough
Copy link
Contributor

@henrik-m - This looks fine to me but I am not a Windows user. Care to add some context or clarify consequences? Thanks

@github-actions github-actions bot removed the stale label Sep 12, 2024
@henrik-m
Copy link
Contributor Author

@philipgough These changes allow the Windows Exporter to run not only on Windows Server 2019, but also on 2022+. The init container was changed to an image with a multi-arch manifest.
The toleration was added to allow the exporter to run in hybrid clusters where the Windows nodes are tainted with os=windows so that linux kubernetes workloads do not get scheduled on them.
And the argument change, iirc, was just a straight fix for more recent versions of the windows exporter image, because the collector.textfile.directory option was deprecated.

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@philipgough philipgough merged commit 2a14b95 into prometheus-operator:main Oct 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants